ResolveInfo::getFieldSelectionWithAliases() => now add instance types and the folded union types to the returned schema. #1681
+281
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
requested changes
Mar 18, 2025
… and the folded union types to the returned schema.
|
Hi, thank you for the review. How should I fix this PHPStan error ?
On tests/Type/ResolveInfoTest.php Line 741 Something like this ?
|
I would do something like this: $fields = $myCustomWithObjectType->config['fields'];
assert(is_array($fields), 'ensured by type config');
$myCustomType = $fields['customA']; |
|
Thank you, released with https://github.com/webonyx/graphql-php/releases/tag/v15.20.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After using the ResolveInfo::getFieldSelectionWithAliases() method I needed some additionnal data in order to go through the all schema properly.
So I have updated the method to add:
Before this update, we were able to go through union types but it was unreliable, some fields with the same name in different unioned types could be substituted for others.
Now it's consistent and it allows me in my application to handle a proper infinite level eager loading across the entire schema with unions.